Merged
Conversation
- All quotes are double qoutes now (except when nested in double quotes) - get_project and get_projects are now one function - get_sessions is now 'get_subject' to match XNAT's nomenclature - Added docstrings to get_projects and get_subject
|
Hello @DESm1th, Thank you for updating! Cheers! There are no style issues detected in this Pull Request. 🍻 To test for issues locally, Comment last updated at 2020-03-10 19:04:47 UTC |
Codecov Report
@@ Coverage Diff @@
## master #265 +/- ##
=========================================
+ Coverage 28.5% 30.81% +2.3%
=========================================
Files 54 54
Lines 8099 8396 +297
=========================================
+ Hits 2309 2587 +278
- Misses 5790 5809 +19
Continue to review full report at Codecov.
|
Contributor
Author
|
I felt like I wrote so many new tests. And then I codecov says +2.31% coverage. Cries internally |
JayHennessy
previously approved these changes
Mar 9, 2020
jerdra
reviewed
Mar 10, 2020
jerdra
reviewed
Mar 10, 2020
jerdra
reviewed
Mar 10, 2020
jerdra
reviewed
Mar 10, 2020
gabiherman
previously approved these changes
Mar 10, 2020
jerdra
reviewed
Mar 10, 2020
jerdra
reviewed
Mar 10, 2020
jerdra
requested changes
Mar 10, 2020
Contributor
jerdra
left a comment
jerdra
left a comment
There was a problem hiding this comment.
Looks great, some minor modifications/questions.
Also bless your hard working soul for those tests ❤️
josephmje
reviewed
Mar 10, 2020
gabiherman
approved these changes
Mar 10, 2020
josephmje
approved these changes
Mar 10, 2020
jerdra
approved these changes
Mar 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates our core scripts that interact with XNAT (and dm_link) to allow zip files and xnat experiments to use the KCNI conventions.
Note: I did NOT yet update dm_link_shared_ids.py, dm_xnat_project_overview.py, or track_scan_dates.py. The first needs a major overhaul (it still doesnt allow SENDEP linking to work right, and predates the dashboard) that I'd like to spend more time on and none of the three will be affected yet by our initial KCNI XNAT test cases. But I'll push that later since we need to move forward.
For studies and sites that we want to start migrating we'll have to update the settings file to add:
XNAT_CONVENTION: KCNI
and for study / site fields that need to be changed for KCNI we'll have to add an id map that matches this format:
ID_MAP:
STUDY: {KCNI_STUDY: DATMAN_STUDY}
SITE: {
KCNI_SITE1: DM_SITE1,
...
KCNI_SITEN: DM_SITEN
}