Skip to content

[FIX] - Bug when SliceTiming length's don't match gold standard#268

Merged
DESm1th merged 3 commits intoTIGRLab:masterfrom
jerdra:headerdiff_fix_value
Mar 17, 2020
Merged

[FIX] - Bug when SliceTiming length's don't match gold standard#268
DESm1th merged 3 commits intoTIGRLab:masterfrom
jerdra:headerdiff_fix_value

Conversation

@jerdra
Copy link
Copy Markdown
Contributor

@jerdra jerdra commented Mar 17, 2020

Issue occurs because ValueError returns a Python False which isn't of type np.bool_(False).

@jerdra jerdra requested review from DESm1th and josephmje and removed request for gabiherman, josephmje and jskocic March 17, 2020 15:46
@gabiherman gabiherman self-requested a review March 17, 2020 16:13
@DESm1th DESm1th merged commit 843728c into TIGRLab:master Mar 17, 2020
Comment thread .gitignore
.nfs*
.*swp
.*.sw*
process.yml
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is process.yml?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was using that during testing, I could remove it.
CircleCI local docker builds requires a YAML file (they use process.yml) for execution

Although it doesn't seem to need to live inside the root dir, so we could remove it if needed (or keep it there for convenience when running local builds)

https://circleci.com/docs/2.0/local-cli/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants