[REF] Allow multiple XNAT servers to be used for upload / extraction#270
Merged
DESm1th merged 17 commits intoTIGRLab:masterfrom Mar 31, 2020
Merged
[REF] Allow multiple XNAT servers to be used for upload / extraction#270DESm1th merged 17 commits intoTIGRLab:masterfrom
DESm1th merged 17 commits intoTIGRLab:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #270 +/- ##
==========================================
+ Coverage 31.04% 31.07% +0.02%
==========================================
Files 54 54
Lines 8430 8490 +60
==========================================
+ Hits 2617 2638 +21
- Misses 5813 5852 +39
Continue to review full report at Codecov.
|
Contributor
Author
|
@edickie , @gabiherman , @jerdra This one is safe to review, I'm done updating it :) (I'm not going to add xnat related tests until we decide on whether to switch to a 3rd party xnat module or not). |
jerdra
previously approved these changes
Mar 30, 2020
Comment on lines
208
to
212
| xnat_projects = get_projects(config) | ||
|
|
||
| # for each XNAT project send out URL request for list of experiment IDs | ||
| # then validate and add (connection, XNAT project, subject ID) to output | ||
| for project in xnat_projects: |
Contributor
There was a problem hiding this comment.
Suggested change
| xnat_projects = get_projects(config) | |
| # for each XNAT project send out URL request for list of experiment IDs | |
| # then validate and add (connection, XNAT project, subject ID) to output | |
| for project in xnat_projects: | |
| # for each XNAT project send out URL request for list of experiment IDs | |
| # then validate and add (connection, XNAT project, subject ID) to output | |
| for project in get_projects(config): |
Contributor
Author
There was a problem hiding this comment.
Nice catch! I couldnt push it exactly as you requested because of the nested loop, but I got rid of line 208
gabiherman
approved these changes
Mar 30, 2020
jerdra
approved these changes
Mar 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I forgot to update dm_xnat_upload and dm_xnat_extract to allow multiple xnat servers to be used for one study :( This fixes this oversight.