[FIX] Experiment renaming failures#272
Merged
DESm1th merged 5 commits intoTIGRLab:masterfrom Jul 17, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #272 +/- ##
==========================================
- Coverage 30.66% 30.65% -0.02%
==========================================
Files 56 56
Lines 8639 8642 +3
==========================================
Hits 2649 2649
- Misses 5990 5993 +3
Continue to review full report at Codecov.
|
jerdra
previously approved these changes
Apr 20, 2020
Contributor
|
how annoying 🙈 |
|
Hello @DESm1th, Thank you for updating! Cheers! There are no style issues detected in this Pull Request. 🍻 To test for issues locally, Comment last updated at 2020-05-25 19:31:52 UTC |
DESm1th
requested review from
josephmje and
jskocic
and removed request for
edickie and
gabiherman
josephmje
approved these changes
Jun 19, 2020
jerdra
approved these changes
Jun 22, 2020
jskocic
approved these changes
Jun 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So apparently some experiments on XNAT can end up with more than one autorun pipeline instance (even though the history in the GUI never shows more than one) and the other instance(s) can hang around and make things fail. I thiiiink this might only happen with older data from before we upgraded XNAT (can't confirm but so far only older experiments have had the problem).