Skip to content

[FIX] Update scanid ID regexes to handle date based KCNI Phantom IDs#280

Merged
DESm1th merged 3 commits intoTIGRLab:masterfrom
DESm1th:bug_fixes
Aug 6, 2020
Merged

[FIX] Update scanid ID regexes to handle date based KCNI Phantom IDs#280
DESm1th merged 3 commits intoTIGRLab:masterfrom
DESm1th:bug_fixes

Conversation

@DESm1th
Copy link
Copy Markdown
Contributor

@DESm1th DESm1th commented Jul 17, 2020

No description provided.

@auto-assign auto-assign bot requested review from edickie, josephmje and jskocic July 17, 2020 16:26
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 17, 2020

Codecov Report

Merging #280 into master will increase coverage by 0.08%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
+ Coverage   30.74%   30.82%   +0.08%     
==========================================
  Files          56       56              
  Lines        8642     8654      +12     
==========================================
+ Hits         2657     2668      +11     
- Misses       5985     5986       +1     
Impacted Files Coverage Δ
datman/scanid.py 86.13% <80.00%> (-0.32%) ⬇️
tests/test_datman_scanid.py 100.00% <100.00%> (ø)
tests/test_scan.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79571b5...b4c62ec. Read the comment docs.

@DESm1th DESm1th merged commit 93c2d7a into TIGRLab:master Aug 6, 2020
@DESm1th DESm1th deleted the bug_fixes branch October 1, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants