Bidsify fix - don't re-write dataset_description.json on every run#281
Bidsify fix - don't re-write dataset_description.json on every run#281DESm1th merged 3 commits intoTIGRLab:masterfrom
Conversation
…ing file. Also added tests for this.
…ing file. Also added tests for this.
|
Thanks for opening this pull request! We have detected this is the first time for you to contribute to datman. Please check out our contributing guidelines. Of course, if you want to opt-out this time there is no problem at all with adding your name later. You will be always welcome to add it in the future whenever you feel it should be listed. |
|
Hello @JayHennessy, Thank you for updating! Cheers! There are no style issues detected in this Pull Request. 🍻 To test for issues locally, Comment last updated at 2020-07-22 19:50:24 UTC |
Codecov Report
@@ Coverage Diff @@
## master #281 +/- ##
==========================================
+ Coverage 30.74% 31.79% +1.05%
==========================================
Files 56 57 +1
Lines 8642 8667 +25
==========================================
+ Hits 2657 2756 +99
+ Misses 5985 5911 -74
Continue to review full report at Codecov.
|
|
Oops, i didn't do a pep8 check. Just made the updates now. |
josephmje
left a comment
There was a problem hiding this comment.
Thanks @JayHennessy . This looks good to me!
DESm1th
left a comment
There was a problem hiding this comment.
Looks good, thanks for adding tests too Jay!
In bin/bidsify.py I just added a check to see if dataset_description.json exists, then don't re-write it if it does.
I also wrote a quick unittest for this for this addition.