Skip to content

Bidsify fix - don't re-write dataset_description.json on every run#281

Merged
DESm1th merged 3 commits intoTIGRLab:masterfrom
JayHennessy:bidsify-fix
Jul 23, 2020
Merged

Bidsify fix - don't re-write dataset_description.json on every run#281
DESm1th merged 3 commits intoTIGRLab:masterfrom
JayHennessy:bidsify-fix

Conversation

@JayHennessy
Copy link
Copy Markdown

In bin/bidsify.py I just added a check to see if dataset_description.json exists, then don't re-write it if it does.

I also wrote a quick unittest for this for this addition.

Jay Hennessy added 2 commits July 22, 2020 15:07
@welcome
Copy link
Copy Markdown

welcome bot commented Jul 22, 2020

Thanks for opening this pull request! We have detected this is the first time for you to contribute to datman. Please check out our contributing guidelines.
We invite you to list yourself as a datman contributor, so if your name is not already mentioned, please modify the .zenodo.json file and insert your data last in the contributors list. Example:

{
   "name": "Contributor, New datman",
   "affiliation": "Department of na na na datman'ing, Open Science Made-Up University",
   "orcid": "<your id>",
   "type": "Researcher"
}

Of course, if you want to opt-out this time there is no problem at all with adding your name later. You will be always welcome to add it in the future whenever you feel it should be listed.

@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Jul 22, 2020

Hello @JayHennessy, Thank you for updating!

Cheers! There are no style issues detected in this Pull Request. 🍻 To test for issues locally, pip install flake8 and then run flake8 datman.

Comment last updated at 2020-07-22 19:50:24 UTC

@auto-assign auto-assign bot requested review from DESm1th, jerdra and josephmje July 22, 2020 19:33
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 22, 2020

Codecov Report

Merging #281 into master will increase coverage by 1.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
+ Coverage   30.74%   31.79%   +1.05%     
==========================================
  Files          56       57       +1     
  Lines        8642     8667      +25     
==========================================
+ Hits         2657     2756      +99     
+ Misses       5985     5911      -74     
Impacted Files Coverage Δ
bin/bidsify.py 19.86% <100.00%> (+19.86%) ⬆️
tests/test_bidsify.py 100.00% <100.00%> (ø)
datman/bids/check_bids.py 19.44% <0.00%> (+19.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79571b5...922873a. Read the comment docs.

@JayHennessy
Copy link
Copy Markdown
Author

Oops, i didn't do a pep8 check. Just made the updates now.

Copy link
Copy Markdown
Contributor

@josephmje josephmje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JayHennessy . This looks good to me!

Copy link
Copy Markdown
Contributor

@DESm1th DESm1th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding tests too Jay!

@DESm1th DESm1th merged commit 11f5fd8 into TIGRLab:master Jul 23, 2020
@JayHennessy JayHennessy deleted the bidsify-fix branch July 23, 2020 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants