[FIX] Removed XNAT integration (was unused)#288
Merged
DESm1th merged 3 commits intoTIGRLab:masterfrom Oct 1, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #288 +/- ##
==========================================
+ Coverage 31.88% 32.02% +0.14%
==========================================
Files 57 57
Lines 8679 8647 -32
==========================================
+ Hits 2767 2769 +2
+ Misses 5912 5878 -34
Continue to review full report at Codecov.
|
josephmje
previously approved these changes
Sep 30, 2020
Contributor
josephmje
left a comment
josephmje
left a comment
There was a problem hiding this comment.
Thanks @DESm1th! Looking good to me. Only question I had is whether there's a reason for switching the logging from StreamHandler to basic config? I don't have any preference on this. I've just been following what was done in the past.
| try: | ||
| project_records = parse_records(response, current_study, id_map) | ||
| except ValueError as e: | ||
| logger.error("Couldnt parse redcap records for server response {}. " |
Contributor
There was a problem hiding this comment.
Suggested change
| logger.error("Couldnt parse redcap records for server response {}. " | |
| logger.error("Couldn't parse redcap records for server response {}. " |
Contributor
Author
|
It's just less verbose. basicConfig just adds a streamhandler. |
Contributor
|
looks much cleaner now! thanks for the refactor Dawn 🥇 |
jerdra
approved these changes
Oct 1, 2020
josephmje
approved these changes
Oct 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We havent used the XNAT integration for linked IDs since the dashboard was made, and now that we're moving studies to the KCNI server it is causing crashes so I've removed it.