Skip to content

[FIX] update add_redcap function call#293

Merged
DESm1th merged 1 commit intoTIGRLab:masterfrom
DESm1th:det_fix
Jan 11, 2021
Merged

[FIX] update add_redcap function call#293
DESm1th merged 1 commit intoTIGRLab:masterfrom
DESm1th:det_fix

Conversation

@DESm1th
Copy link
Copy Markdown
Contributor

@DESm1th DESm1th commented Jan 6, 2021

Needed to handle function signature changes from TIGRLab/datman-dashboard#67

@DESm1th DESm1th requested review from jerdra and josephmje January 6, 2021 02:07
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 6, 2021

Codecov Report

Merging #293 (64bd30a) into master (c18bbbb) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #293   +/-   ##
=======================================
  Coverage   32.36%   32.36%           
=======================================
  Files          60       60           
  Lines        8890     8890           
=======================================
  Hits         2877     2877           
  Misses       6013     6013           
Impacted Files Coverage Δ
bin/dm_redcap_scan_completed.py 23.80% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c18bbbb...64bd30a. Read the comment docs.

event_id=event_id,
version=redcap_version)
session.add_redcap(
record_id, session_date, project=redcap_project, url=redcap_url,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this include date=session_date ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nvm didn't realize that the old function had changed!

@DESm1th DESm1th merged commit e0a27bf into TIGRLab:master Jan 11, 2021
@DESm1th DESm1th deleted the det_fix branch February 5, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants