[FIX] Prevent error log messages from being lost#295
Merged
DESm1th merged 4 commits intoTIGRLab:masterfrom Feb 5, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
==========================================
+ Coverage 32.15% 32.16% +0.01%
==========================================
Files 60 60
Lines 8948 8950 +2
==========================================
+ Hits 2877 2879 +2
Misses 6071 6071
Continue to review full report at Codecov.
|
Contributor
|
Thanks for updating this Dawn! |
jerdra
approved these changes
Feb 1, 2021
jskocic
approved these changes
Feb 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the dashboard config (https://github.com/TIGRLab/dashboard/blob/master/config/logging.py) I set datman logging to critical to reduce log spam a while back. It turns out that this setting was quietly taking effect on all the scripts in
datman/datmanalways, because config imports part of the dashboard.So! If we instead set it to warn in
datman/__init__.py, we still get less logging when the dashboard is running or imported but we get our error messages back when datman components are imported (even if datman imports the dashboard)