Skip to content

[FIX] Prevent error log messages from being lost#295

Merged
DESm1th merged 4 commits intoTIGRLab:masterfrom
DESm1th:log_fix
Feb 5, 2021
Merged

[FIX] Prevent error log messages from being lost#295
DESm1th merged 4 commits intoTIGRLab:masterfrom
DESm1th:log_fix

Conversation

@DESm1th
Copy link
Copy Markdown
Contributor

@DESm1th DESm1th commented Jan 28, 2021

In the dashboard config (https://github.com/TIGRLab/dashboard/blob/master/config/logging.py) I set datman logging to critical to reduce log spam a while back. It turns out that this setting was quietly taking effect on all the scripts in datman/datman always, because config imports part of the dashboard.

So! If we instead set it to warn in datman/__init__.py, we still get less logging when the dashboard is running or imported but we get our error messages back when datman components are imported (even if datman imports the dashboard)

@auto-assign auto-assign bot requested review from benselby, edickie and jerdra January 28, 2021 23:29
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 28, 2021

Codecov Report

Merging #295 (8143b47) into master (ef9563a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #295      +/-   ##
==========================================
+ Coverage   32.15%   32.16%   +0.01%     
==========================================
  Files          60       60              
  Lines        8948     8950       +2     
==========================================
+ Hits         2877     2879       +2     
  Misses       6071     6071              
Impacted Files Coverage Δ
datman/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef9563a...8143b47. Read the comment docs.

@jerdra
Copy link
Copy Markdown
Contributor

jerdra commented Feb 1, 2021

Thanks for updating this Dawn!

@DESm1th DESm1th requested review from jskocic and removed request for edickie February 4, 2021 21:49
@DESm1th DESm1th merged commit 9d41faa into TIGRLab:master Feb 5, 2021
@DESm1th DESm1th deleted the log_fix branch February 5, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants