Merged
Conversation
add logging module and skip subjects with existing files
josephmje
reviewed
Jun 15, 2021
| outdir = os.path.join(config.get_path('data'), 'tshirt') | ||
|
|
||
| os.makedirs(outdir, exist_ok=True) | ||
| logger.debug('Output location set to: {}'.format(outdir)) |
Contributor
There was a problem hiding this comment.
Suggested change
| logger.debug('Output location set to: {}'.format(outdir)) | |
| logger.debug(f'Output location set to: {outdir}') |
josephmje
previously approved these changes
Jun 15, 2021
jerdra
reviewed
Jun 16, 2021
Contributor
jerdra
left a comment
jerdra
left a comment
There was a problem hiding this comment.
looks good! just a minor nitpick on --output
jerdra
reviewed
Jun 16, 2021
josephmje
reviewed
Jun 16, 2021
|
Hello @kyjimmy, Thank you for updating!
To test for issues locally, |
josephmje
approved these changes
Jun 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add logging module and skip subjects with existing files