[FIX] Update how derived scans are handled#306
Merged
DESm1th merged 1 commit intoTIGRLab:masterfrom Jun 17, 2021
Merged
Conversation
… tag) TAY01 ASL scans weren't being pulled down because they had no image_type listed and were being assumed to be derived. This swaps the order of the checks so that by the time we check if a scan is derived we already know it has a matching tag and therefore it's very likely a scan we want to download.
DESm1th
requested review from
josephmje and
kyjimmy
and removed request for
benselby
Codecov Report
@@ Coverage Diff @@
## master #306 +/- ##
=======================================
Coverage 31.94% 31.94%
=======================================
Files 61 61
Lines 9037 9037
=======================================
Hits 2887 2887
Misses 6150 6150
Continue to review full report at Codecov.
|
josephmje
approved these changes
Jun 14, 2021
kyjimmy
approved these changes
Jun 14, 2021
kyjimmy
approved these changes
Jun 14, 2021
jerdra
approved these changes
Jun 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TAY01 ASL scans weren't being pulled down because they didnt have an 'image_type' and were being assumed to be derived scans. This swaps the order of the checks so that we only check if something is derived if it matches a tag, and changes the default behavior to assume that those without image_types are not derived.