Conversation
kyjimmy
left a comment
kyjimmy
left a comment
There was a problem hiding this comment.
Variables name in the output text file of TAY project is different from other other projects.
|
|
||
| log_head, log_tail = os.path.split(eprimefile) | ||
|
|
||
| if not out_dir: |
There was a problem hiding this comment.
--output-dir OUT_DIR Specify an alternate output directory [Default: $DATMAN_PROJECTSDIR/{study}/data/nii/{session}]
Wouldn't out_dir never be empty since there's a default value? Please correct me if I am wrong.
There was a problem hiding this comment.
out_dir would be empty if the --output-dir arg isn't specified. The default in the docstring is just so the user knows it'll be put into the configured archive folder, it won't actually set a value (docopt will silently fail to make it a real value).
|
|
||
| Usage: | ||
| dm_parse_faces.py [options] <study> | ||
| dm_parse_faces.py [options] <study> [<session>] |
There was a problem hiding this comment.
Would this need to take multiple sessions? Can add [<session>]...
| nii_path, ident.get_full_subjectid_with_timepoint()) | ||
|
|
||
| file_name = os.path.join(out_dir, f"{ses}_FACES.tsv") | ||
| os.makedirs(os.path.dirname(file_name), exist_ok=True) |
There was a problem hiding this comment.
Should this bit be moved to within the if not dryrun statement?
|
Hello @jerdra, Thank you for updating! Cheers! There are no style issues detected in this Pull Request. 🍻 To test for issues locally, Comment last updated at 2021-06-17 15:29:25 UTC |
5 participants
Fixed up PEP8 issues and added a bit more clarity to logging