Skip to content

Added fix for SPN30/31 redcap issues#310

Merged
DESm1th merged 3 commits intoTIGRLab:masterfrom
DESm1th:spn30_fix
Sep 16, 2021
Merged

Added fix for SPN30/31 redcap issues#310
DESm1th merged 3 commits intoTIGRLab:masterfrom
DESm1th:spn30_fix

Conversation

@DESm1th
Copy link
Copy Markdown
Contributor

@DESm1th DESm1th commented Sep 2, 2021

When pulling redcap records from SPN30/31 constant 'duplicate record' exceptions were happening because SPN31 config causes the SPN30_CMH IDs to be read as SPN30_CMP and the script attempts to readd the record. This will stop the bad ID conversions from happening so records can be added correctly.

@DESm1th DESm1th requested a review from josephmje September 2, 2021 17:41
@auto-assign auto-assign bot requested review from jerdra and jskocic September 2, 2021 17:41
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 2, 2021

Codecov Report

Merging #310 (197bed3) into master (7027b36) will increase coverage by 0.14%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
+ Coverage   31.39%   31.53%   +0.14%     
==========================================
  Files          62       62              
  Lines        9196     9218      +22     
==========================================
+ Hits         2887     2907      +20     
- Misses       6309     6311       +2     
Impacted Files Coverage Δ
tests/test_dm_redcap_scan_completed.py 94.91% <90.00%> (-2.53%) ⬇️
bin/dm_redcap_scan_completed.py 25.00% <100.00%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7027b36...197bed3. Read the comment docs.

@DESm1th DESm1th merged commit 9db754f into TIGRLab:master Sep 16, 2021
@DESm1th DESm1th deleted the spn30_fix branch September 16, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants