Skip to content

[FIX] Deal with circleci errors#316

Merged
DESm1th merged 6 commits intoTIGRLab:masterfrom
DESm1th:circleci-editor/454/master
Nov 17, 2021
Merged

[FIX] Deal with circleci errors#316
DESm1th merged 6 commits intoTIGRLab:masterfrom
DESm1th:circleci-editor/454/master

Conversation

@DESm1th
Copy link
Copy Markdown
Contributor

@DESm1th DESm1th commented Nov 10, 2021

This fixes:

  • An out of date datman test
  • An issue with sphinx/docutils failing to build valid docs
  • A call to checksum a file that hadnt yet been checked out that was causing errors

@auto-assign auto-assign bot requested review from benselby, jerdra and jskocic November 10, 2021 19:08
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 10, 2021

Codecov Report

Merging #316 (5ef93b2) into master (a2fbd26) will increase coverage by 8.75%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #316      +/-   ##
==========================================
+ Coverage   22.63%   31.38%   +8.75%     
==========================================
  Files          61       61              
  Lines        9123     9125       +2     
==========================================
+ Hits         2065     2864     +799     
+ Misses       7058     6261     -797     
Impacted Files Coverage Δ
tests/test_dm_qc_report.py 100.00% <100.00%> (+29.94%) ⬆️
tests/test_scan.py 100.00% <100.00%> (+68.00%) ⬆️
datman/header_checks.py 18.07% <0.00%> (+3.61%) ⬆️
datman/utils.py 18.03% <0.00%> (+5.34%) ⬆️
bin/dm_xnat_upload.py 20.90% <0.00%> (+6.81%) ⬆️
bin/dm_redcap_scan_completed.py 25.00% <0.00%> (+7.81%) ⬆️
datman/config.py 57.63% <0.00%> (+10.76%) ⬆️
bin/dm_qc_report.py 31.75% <0.00%> (+11.05%) ⬆️
datman/xnat.py 27.67% <0.00%> (+16.47%) ⬆️
datman/scan.py 93.13% <0.00%> (+18.62%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2fbd26...5ef93b2. Read the comment docs.

@DESm1th DESm1th merged commit 1a125f4 into TIGRLab:master Nov 17, 2021
@DESm1th DESm1th deleted the circleci-editor/454/master branch November 17, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants