Wrapped dcm2bids import in exception message for better messaging#319
Merged
Wrapped dcm2bids import in exception message for better messaging#319
Conversation
Codecov Report
@@ Coverage Diff @@
## master #319 +/- ##
==========================================
- Coverage 30.93% 30.90% -0.03%
==========================================
Files 62 62
Lines 9259 9267 +8
==========================================
Hits 2864 2864
- Misses 6395 6403 +8
Continue to review full report at Codecov.
|
jerdra
requested changes
Nov 30, 2021
Contributor
jerdra
left a comment
jerdra
left a comment
There was a problem hiding this comment.
Just a minor update to the error message suggesting how to amend the error. Thanks for the quick fix Salim!
Co-authored-by: Jerry Jeyachandra <jerrold.jeyachandra@gmail.com>
jerdra
approved these changes
Nov 30, 2021
DESm1th
approved these changes
Nov 30, 2021
Contributor
|
Thanks Salim! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick fix for wrapping dcm2bids import in an exception in case the user does not want to import it for using regular dm_xnat_extract, or is not able to find it while using the
--use-dcm2bidsflag.In the future I will look into adding a more graceful approach such as the current dashboard imports but this is just a quick fix for now.