Updates and bug fixes for dm_parse_faces#320
Merged
DESm1th merged 3 commits intoTIGRLab:masterfrom Jan 12, 2022
Merged
Conversation
|
Hello @benselby, Thank you for updating! Cheers! There are no style issues detected in this Pull Request. 🍻 To test for issues locally, Comment last updated at 2022-01-12 16:52:23 UTC |
DESm1th
approved these changes
Jan 12, 2022
Contributor
DESm1th
left a comment
DESm1th
left a comment
There was a problem hiding this comment.
Thanks for fixing this Ben!
jerdra
approved these changes
Jan 12, 2022
| f"with {enc} encoding: {e}") | ||
| continue | ||
|
|
||
| raise UnicodeError("Unable to find appropriate encoding") |
Contributor
There was a problem hiding this comment.
would an IOError be more appropriate here? A missing Header line doesn't have to mean its a encoding issue, could just be a truncated file w/correct encoding.
I'm nitpicking here, so feel free to ignore if you disagree
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the break I realized that there was a bug in the FACES parser that was resulting in output tsvs not being saved in the correct nii/ directories. Also a few of the OPT session .txt files had UTF-16 encoding issues wherein the files were not being decoded properly due to a missing BOM, so I added some code to try specifying endianness which resolves most issues.