Skip to content

[FIX] Fix errors from updating dashboard#323

Merged
DESm1th merged 3 commits intoTIGRLab:masterfrom
DESm1th:hotfixes
Feb 15, 2022
Merged

[FIX] Fix errors from updating dashboard#323
DESm1th merged 3 commits intoTIGRLab:masterfrom
DESm1th:hotfixes

Conversation

@DESm1th
Copy link
Copy Markdown
Contributor

@DESm1th DESm1th commented Feb 9, 2022

Jer noticed some more errors (Thanks Jer!) from my recent update to the dashboard table organization. This fixes the last of the errors and also rolls out two fixes for older issues

  • The addition of the ExpectedScan table means that study.scantypes returns an ExpectedScan object instead of directly returning Scantype, so to get the string tag name line 313 needs to use st.scantype_id. It also means a site name has to be given to get the list of scantypes from a dashboard Study object. af385eb
  • This also removes a reference to a variable that was removed from datman.xnat.XNATExperiment ages ago and that was causing periodic exceptions aba55cb
  • And makes the dm_deface script executable by default ae79263

@auto-assign auto-assign bot requested review from jerdra, josephmje and jskocic February 9, 2022 18:26
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 9, 2022

Codecov Report

Merging #323 (ae79263) into master (322b28f) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #323   +/-   ##
=======================================
  Coverage   30.87%   30.88%           
=======================================
  Files          62       62           
  Lines        9275     9273    -2     
=======================================
  Hits         2864     2864           
+ Misses       6411     6409    -2     
Impacted Files Coverage Δ
bin/dm_deface.py 0.00% <ø> (ø)
datman/dashboard.py 27.80% <0.00%> (ø)
datman/xnat.py 27.74% <ø> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 322b28f...ae79263. Read the comment docs.

@DESm1th DESm1th merged commit 8869637 into TIGRLab:master Feb 15, 2022
@DESm1th DESm1th deleted the hotfixes branch February 15, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants