Skip to content

ENH: Update configuration options for defacing#328

Merged
DESm1th merged 2 commits intoTIGRLab:masterfrom
josephmje:fix/deface
Jun 9, 2022
Merged

ENH: Update configuration options for defacing#328
DESm1th merged 2 commits intoTIGRLab:masterfrom
josephmje:fix/deface

Conversation

@josephmje
Copy link
Copy Markdown
Contributor

This updates the behaviour of dm_deface.py to replace the original scan by default. If the --separate flag is used, the script will output a new file in the BIDS folder using the acq-defaced tag (can be used for SPN20 and RMA01 where we still need the original files for TMS).

@auto-assign auto-assign bot requested review from DESm1th, benselby and jerdra March 17, 2022 19:09
@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Mar 17, 2022

Hello @josephmje, Thank you for updating!

Cheers! There are no style issues detected in this Pull Request. 🍻 To test for issues locally, pip install flake8 and then run flake8 datman.

Comment last updated at 2022-03-17 19:28:09 UTC

@josephmje josephmje force-pushed the fix/deface branch 2 times, most recently from d2e862d to 79bf33e Compare March 17, 2022 19:21
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 17, 2022

Codecov Report

Merging #328 (ca49165) into master (4d3096d) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
- Coverage   30.83%   30.76%   -0.08%     
==========================================
  Files          63       63              
  Lines        9501     9524      +23     
==========================================
  Hits         2930     2930              
- Misses       6571     6594      +23     
Impacted Files Coverage Δ
bin/dm_deface.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d3096d...ca49165. Read the comment docs.

Copy link
Copy Markdown
Contributor

@DESm1th DESm1th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this Mike!

@DESm1th DESm1th merged commit 104404d into TIGRLab:master Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants