FIX: Handle sessions (repeats) appropriately in matching algorithm#331
Merged
DESm1th merged 2 commits intoTIGRLab:masterfrom Jun 3, 2022
Merged
FIX: Handle sessions (repeats) appropriately in matching algorithm#331DESm1th merged 2 commits intoTIGRLab:masterfrom
DESm1th merged 2 commits intoTIGRLab:masterfrom
Conversation
|
Hello @jerdra, Thank you for updating! Cheers! There are no style issues detected in this Pull Request. 🍻 To test for issues locally, Comment last updated at 2022-06-03 14:42:32 UTC |
DESm1th
approved these changes
Jun 3, 2022
josephmje
approved these changes
Jun 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously bidsify was using just the series number but this is an incorrect assumption when repeats are included. This fix adds a filter to the list of potential candidate scans by additionally matching on the session number.