[FIX] qc_report consuming all db connections + queue jobs timing out#332
Merged
DESm1th merged 5 commits intoTIGRLab:masterfrom Jul 19, 2022
Merged
[FIX] qc_report consuming all db connections + queue jobs timing out#332DESm1th merged 5 commits intoTIGRLab:masterfrom
DESm1th merged 5 commits intoTIGRLab:masterfrom
Conversation
larger nifti files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the move to the new dynamic QC pages tons of QC jobs were submitted to generate metrics that were (for some reason) missing from the QC folders. This large number of jobs consumed all available database connections. This was because SQLAlchemy opens a transaction whenever database reads happen and doesn't close them until the next commit/rollback. dm_qc_report was reading some values from the database prior to generating metrics, which left connections open 'idle in transaction' for 30+ minutes while the metrics were created.
This PR: