ENH: Add --match-series option to enforce that matches Series# is found#342
Merged
DESm1th merged 1 commit intoTIGRLab:mainfrom Nov 24, 2022
Merged
Conversation
DESm1th
approved these changes
Nov 24, 2022
Contributor
|
That's a good point! I'll push a PR shortly to fix that (and another to fix the failing github actions). Thanks Jer! |
slimnsour
approved these changes
Nov 24, 2022
Contributor
slimnsour
left a comment
slimnsour
left a comment
There was a problem hiding this comment.
Great addition Jer, and implementation looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This appends the Series number onto the task files so that .tsv outputs can be properly associated with their scans. Currently the default behavior means that files will overwrite each other in an indeterminate manner if there are multiple files for the same EA part.
@DESm1th i think maybe with blacklisting it might be a good idea to also remove .tsv files?