[ENH] un-hardcode dm_blacklist_rm's list of directories to purge from#344
Merged
DESm1th merged 2 commits intoTIGRLab:mainfrom Dec 13, 2022
Merged
[ENH] un-hardcode dm_blacklist_rm's list of directories to purge from#344DESm1th merged 2 commits intoTIGRLab:mainfrom
DESm1th merged 2 commits intoTIGRLab:mainfrom
Conversation
jerdra
approved these changes
Dec 9, 2022
Comment on lines
+15
to
+20
| --path KEY If provided overrides the 'blacklist_rm' setting | ||
| from the config files, which defines the directories | ||
| to delete blacklisted items from. 'KEY' may be the name | ||
| of any path defined in the main config file (e.g. | ||
| 'nii'). This option can be repeated to include multiple | ||
| paths. |
Contributor
There was a problem hiding this comment.
Might be a good idea to specify that this option can be specified multiple times. Its implicit in the usage syntax but not obvious if you aren't already familiar!
slimnsour
approved these changes
Dec 13, 2022
Contributor
slimnsour
left a comment
slimnsour
left a comment
There was a problem hiding this comment.
Great implementation Dawn!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates dm_blacklist_rm to use a config value (BlacklistRm) or command line arg (--path) to override the default list of paths to purge blacklisted files from.