ENH: Enable XnatType key in ExportInfo#345
Merged
DESm1th merged 1 commit intoTIGRLab:mainfrom Dec 13, 2022
Merged
Conversation
…_field to match tags on
slimnsour
approved these changes
Dec 13, 2022
Contributor
slimnsour
left a comment
slimnsour
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for implementing this!
DESm1th
approved these changes
Dec 13, 2022
Contributor
DESm1th
left a comment
DESm1th
left a comment
There was a problem hiding this comment.
Thanks for doing this Jer! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables users to use the
XnatTypekey in lieu ofSeriesDescriptionwithin a study'sExportInfo. The result is that tag identification will happen using XNAT'sTypedata field.The justification behind using this feature is that XNAT's
Typedata-field is editable whereas SeriesDescription is not. As a result XNAT Project owners/maintainers can override the SeriesDescription if the original SeriesDescription doesn't properly allow us to identify an appropriate Tag.Also this is a my bad moment but I habitually run yapf when saving code and it formatted a bunch of irrelevant lines.... For the actual changes made look at: