Skip to content

[FIX] Stop test failures, permissions issue, and failing auto-assign#347

Merged
DESm1th merged 6 commits intoTIGRLab:mainfrom
DESm1th:fix_actions
Feb 28, 2023
Merged

[FIX] Stop test failures, permissions issue, and failing auto-assign#347
DESm1th merged 6 commits intoTIGRLab:mainfrom
DESm1th:fix_actions

Conversation

@DESm1th
Copy link
Copy Markdown
Contributor

@DESm1th DESm1th commented Jan 13, 2023

This pull request addresses a few remaining github actions issues

  • 432ce4a allows newer versions of nibabel to be installed. This fixes test failures that were happening because the outdated version of nibabel was referencing a numpy attribute that doesnt exist for newer versions of numpy.
  • 74a2900 updates the run_tests code coverage comment step to use a different token with comment writing permissions to fix a permission error.
  • e31adb9 updates how we auto assign code reviewers. The github actions pipeline is still often failing to correctly assign reviewers. This will instead use github teams + the code owners file to always assign me and then randomly assign two additional reviewers for datman PRs

@github-actions github-actions bot requested review from jerdra and slimnsour January 13, 2023 21:29
@github-actions github-actions bot added the fix Tagged PR fixes a bug label Jan 13, 2023
@DESm1th DESm1th merged commit 12026bf into TIGRLab:main Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Tagged PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant