fix: version-bump-check parser silently passes all PRs#28
Merged
TMHSDigital merged 1 commit intomainfrom Apr 25, 2026
Merged
Conversation
The version-bump-check job in validate.yml uses git log --pretty=format:'%H%x00%s%x00%b%x1e' to extract commits and parse them. Bash command substitution silently strips \0 bytes (with a warning to stderr that nothing inspects), gluing SHA+SUBJECT+BODY into one field. The regex that extracts conventional-commit prefixes never matched, so the check has been silently passing every PR since 2026-04-22 (commit f27e37f). PR #22 (DTD#4 fix) was a fix:-prefixed PR that did not bump VERSION. The check should have failed it but did not, allowing the PR to merge and causing the next release to fail. Replaces \x00 with \x1f (Unit Separator) which preserves through bash command substitution. The record separator (\x1e Record Separator) was already safe and is unchanged. The awk -F arguments are updated to match. Closes #24. Signed-off-by: 154358121+TMHSDigital@users.noreply.github.com Made-with: Cursor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
version-bump-checkjob invalidate.yml. The job has been silently passing every PR since 2026-04-22 due to bash command substitution stripping\0separators in thegit logoutput, causing the regex parser to never match.Replaces
\x00with\x1f(Unit Separator), which preserves through bash command substitution. The record separator (\x1e) was already safe and is unchanged.Closes #24.
Verification
This PR's commit prefix is
fix:AND it bumpsVERSION(1.8.4→1.8.5). The fixed check should pass on this PR (legitimately — because of the bump).Functional verification of the fix happens on a subsequent deliberate test PR: a
feat:/fix:PR without aVERSIONbump should now fail the check red.