Skip to content

fix: remove paths-ignore from release.yml so content-only changes still gate releases on commit prefix#53

Merged
TMHSDigital merged 1 commit intomainfrom
fix/remove-paths-ignore-from-release-yml-dtd50
Apr 26, 2026
Merged

fix: remove paths-ignore from release.yml so content-only changes still gate releases on commit prefix#53
TMHSDigital merged 1 commit intomainfrom
fix/remove-paths-ignore-from-release-yml-dtd50

Conversation

@TMHSDigital
Copy link
Copy Markdown
Owner

Closes DTD#50. Mirrors the DTD#47 surgery already applied across all eight tool repos (CFX, Unity, Docker, Home-Lab, Monday, Steam-Cursor, Blender, Plaid).

The bug

The meta-repo's release.yml was the only release workflow in the ecosystem still carrying a paths-ignore block:

paths-ignore:
  - "*.md"
  - "docs/**"
  - "standards/**"
  - "LICENSE"
  - ".github/release-drafter.yml"

This was load-bearing under the old commit-prefix-driven release model (where docs/standards changes shouldn't fire a bump), but the meta-repo's release workflow now uses VERSION-vs-latest-tag detection (DTD#23). Under that model:

  • A docs change without a VERSION bump → workflow runs, finds VERSION matches latest tag → no-ops cleanly.
  • A docs change WITH a VERSION bump → workflow should fire and release. The paths-ignore block silently swallowed exactly this case if the commit only touched paths in the ignore list.

The asymmetry: the workflow's own decision logic is correct and self-defending, but the trigger filter prevented it from running in the very case where it would have made the right call.

The fix

Remove paths-ignore entirely. Every push to main reaches the workflow; the VERSION-vs-tag check decides whether to release.

Diff shape

  • release.yml: minus 6 lines (paths-ignore block).
  • VERSION: 1.9.4 -> 1.9.5 (PATCH bump for workflow config fix; also serves as end-to-end verification - this very commit, which only touches workflow YAML, was previously excluded by the old filter).

Verification plan

After merge, the workflow should:

  1. Fire on the merge commit (no longer filtered out).
  2. Detect VERSION (1.9.5) > latest tag (v1.9.4).
  3. Tag v1.9.5, update floating @v1 and @v1.9, draft a release.

If the workflow does NOT fire, that's a regression in this same fix and I'll report immediately.

Cross-reference

DTD#47 (tool-repo paths-ignore removal) and DTD#51 (release-doc-sync staging fix) both landed earlier this session. After this merges, the entire ecosystem's release-trigger and release-staging behavior is uniform and correct.

Closes #50.

…ll gate releases on commit prefix

Closes DTD#50. Mirrors DTD#47 pattern fixed across the tool repos. The previous paths-ignore block excluded `*.md`, `docs/`, `standards/`, `LICENSE`, and `release-drafter.yml` from triggering the workflow, but the meta-repo's release.yml uses VERSION-vs-latest-tag semantics (not commit-prefix). The result was content edits to standards/ or docs/ that bumped VERSION still got skipped at trigger time. Removing the block lets every push to main reach the workflow; the VERSION-vs-tag check then correctly decides whether to release. Bumps VERSION 1.9.4 -> 1.9.5 to validate the fix end-to-end (this very commit will both bump VERSION and previously would have been excluded; with the fix it should fire and release v1.9.5).

Made-with: Cursor
@github-actions
Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions github-actions Bot added the ci label Apr 26, 2026
@TMHSDigital TMHSDigital merged commit 1181ee5 into main Apr 26, 2026
13 checks passed
@TMHSDigital TMHSDigital deleted the fix/remove-paths-ignore-from-release-yml-dtd50 branch April 26, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

meta-repo's own release.yml retains paths-ignore patterns; same systemic bug as DTD#47

1 participant