fix: write temp working files to the OS temp dir, not the edits dir (#24)#30
Merged
Conversation
) concat (its demuxer list file) and title_card (its drawtext textfile) wrote dotfiles into SCREENCAST_HOME/edits and removed them in a finally block; a hard crash leaked them next to real outputs. Route both through a new tempPath() helper in utils/paths.ts that returns a unique path under os.tmpdir(), so the OS reaps any leftover. Normal-path cleanup is unchanged. Fixes #24 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24.
Problem
concat(its demuxer list file) andtitle_card(its drawtext textfile) wrote dotfiles intoSCREENCAST_HOME/editsand removed them in afinally. A hard crash between write and cleanup leaked them next to real outputs.Fix
Add a
tempPath()helper inutils/paths.tsthat returns a unique path underos.tmpdir(), and route both temp files through it. Normal-path cleanup is unchanged; any leftover after a crash is reaped by the OS.Verification
npm run build,npm run typecheck,npm testpass (131 passed, 5 skipped; +2 tests fortempPath).🤖 Generated with Claude Code