Revert action-gh-release v3 bump (PR #9): v3 breaks parallel release matrix#18
Merged
Conversation
This reverts commit 0925ada (PR #9). Smoke test (throwaway tag v0.6.1-rc1) showed action-gh-release@v3 breaks the parallel release matrix in go.yml. The 5 matrix jobs each create the same release for the tag; v3 added a "Finalizing release" update step that fails with "Validation Failed: already_exists (tag_name)" when the jobs race, so the run failed (fail-fast cancelled the rest) and only 4 of 10 assets uploaded plus a leftover draft release. The same matrix publishes all 10 assets reliably on @v2 (v0.5.1 and v0.6.0). Staying on @v2 (Node 20) keeps releases working. Adopting v3 would require serializing release creation (e.g. a dedicated create-release job before the upload matrix, or softprops make_latest/overwrite handling) - tracked separately. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #9. The v0.6.1-rc1 smoke test failed: action-gh-release@v3 added a 'Finalizing release' update step that errors with 'Validation Failed: already_exists (tag_name)' when the 5 parallel matrix jobs race to create the same release. Result: run failed, only 4/10 assets, leftover draft release. The same matrix works on @v2 (v0.5.1, v0.6.0 each got 10 assets). Staying on @v2 keeps releases working; v3 adoption needs serialized release creation (separate create-release job).