ci: serialize release creation so the upload matrix never races#19
Merged
Conversation
Splits the tag release path in go.yml into two stages: - create-release: a single job (needs build) that ensures the GitHub release for the tag exists before any assets are uploaded, so exactly one job owns release creation. - upload-assets: the existing 5-way build matrix (needs create-release) that builds each binary plus its .sha256 and only adds files to the already existing release. This removes the concurrent-create race where all five matrix jobs tried to create the same release. It worked on action-gh-release@v2 only by luck and failed on @V3 with "already_exists (tag_name)". With creation serialized, v3 is safe to adopt. Preserves the same 5 platform targets, asset names, 10 total assets (5 binaries plus 5 .sha256), checksum generation, GITHUB_TOKEN usage, and contents: write only on the release stages. Still on @v2 in this commit; the @V3 bump lands separately after validation. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits the tag release path into create-release (single job, owns creation) + upload-assets (5-way matrix, needs create-release, only adds files). Removes the concurrent-create race that failed on action-gh-release@v3 with 'already_exists (tag_name)'. Preserves 5 targets, asset names, 10 assets, checksums, GITHUB_TOKEN, contents: write on release stages. Still @v2 here; @V3 bump lands after rc validation.