How to check that dependencies injected in the constructor of classes only match certain conditions?

[dvdciri]

I'm looking for a way to check that all classes (that match certain conditions) can have only certain dependencies injected in the constructor.

i.e. All classes that end with test can only have classes that end with foo or bar in the constructor, a class that end with foobar would make the test fail.

Is there a way to do that?

[codecholeric]

I hope I understood your problem, but what about

@ArchTest
static ArchRule injected_constructors_of_tests_have_correct_types =
        constructors()
                .that().areDeclaredInClassesThat().haveSimpleNameEndingWith("Test")
                .and().areAnnotatedWith(Inject.class)
                .should().haveRawParameterTypes(endingWithAnyOf("foo", "bar"));

private static DescribedPredicate<List<JavaClass>> endingWithAnyOf(String... suffixes) {
    return new DescribedPredicate<List<JavaClass>>("ending with any of %s", Arrays.toString(suffixes)) {
        @Override
        public boolean apply(List<JavaClass> parameterTypes) {
            Predicate<JavaClass> hasCorrectSuffix = clazz -> 
                    Arrays.stream(suffixes).anyMatch(suffix -> clazz.getSimpleName().endsWith(suffix));
            return parameterTypes.stream().allMatch(hasCorrectSuffix);
        }
    };
}

Does this get you started?

[dvdciri]

Oh yes, absolutely. I definitely see new methods that I wasn't aware of and this custom predicate is exactly what I need. Thanks a lot.

I don't necessarily need to check the presence of the annotation but is definitely something that I can do.
Am I right saying there is no method to do something like the custom predicate, where you don't have a orShould, or a andShould but you have a anyOf, kind of assertion?

Cause that is what was driving me crazy :)

[codecholeric]

I don't know if I understand correctly, but you could OR up some predicates like

should().dependOnClassesThat(myPredicate1.or(myPredicate2).or(myPredicate3))

A should(anyOf(conditions)) does not exist, but would be easy to write (but you can also just OR conditions, like condition1.or(condition2))

[codecholeric]

If that does not help you, maybe show me a concrete example so I can better understand 😉

[dvdciri]

Yes that is exactly what I was looking for, thanks a lot we can close this :)