Improved the Fluent API by reworking methods that take string parameters to match against the name of types or members #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt API. Instead, an IObjectProvider should be used (e.g. Types().That().HaveFullNameMatching(...)), since this allows for more flexiblity and is much clearer, what you are matching against. Added TODOs to split the methods for matching names with string into separate methods for regex and string equality.
…oads of fluent methods were removed
…le<IType> types), which was equal to HaveDependencyInMethodBodyTo(IEnumerable<IType> types)
…hod parameter to change between string equality checks and regex matching by two separate methods. Removed some more redundant methods in the Fluent API with strings as arguments, that can be replaced by equivalent expressions by invoking the method with an IObjectProvider created by the fluent syntax.
…pected test output
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
==========================================
+ Coverage 65.65% 69.20% +3.54%
==========================================
Files 255 255
Lines 23032 19644 -3388
Branches 1962 1680 -282
==========================================
- Hits 15121 13594 -1527
+ Misses 7366 5576 -1790
+ Partials 545 474 -71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced all occurences where useRegularExpressions was used as a method parameter to change between string equality checks and regex matching by two separate methods (e.g.
HaveName(string pattern, bool useRegularExpressions = false)is replaced byHaveName(string name)andHaveNameMatching(string pattern))Removed redundant overloads with string parameters from some methods in the Fluent API, where an IObjectProvider can be used instead to create an equivalent or more precisely defined rule (e.g.
Types().That().DependOnAny("ExampleClass")can be replaced byTypes().That().DependOnAny(Types().That().HaveName("ExampleClass"))).Fixed a bug in the implementation of
NotHaveDependencyInMethodBodyTo(IEnumerable<IType> types)inMethodMemberConditionsDefinition, which resulted in the method behaving like the negationHaveDependencyInMethodBodyTo(IEnumerable<IType> types).