ensure that contents are encoded utf-8 for pako lib#196
Merged
janschaefer merged 1 commit intoTNG:masterfrom Mar 15, 2016
Merged
ensure that contents are encoded utf-8 for pako lib#196janschaefer merged 1 commit intoTNG:masterfrom
janschaefer merged 1 commit intoTNG:masterfrom
Conversation
janschaefer
added a commit
that referenced
this pull request
Mar 15, 2016
ensure that contents are encoded utf-8 for pako lib
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This occurs when running on an OS without UTF-8 as default charset (i.e. windows machines). This problem has been introduced in #186.
I found it hard to provide an automated test for this. Therefore I looked at JGiven's own report before and after regarding the German test cases.
Please double-check if this still works on UTF-8 (well, it should, shouldn't it?)