Fixes #494, i.e. the bug that additional stages in JUnit5 are not injected as Spring Beans.#495
Merged
l-1squared merged 1 commit intoTNG:masterfrom Oct 6, 2020
Conversation
…injected as Spring Beans. Note that the JUnit5 Extensions have to be executed in the correct order, meaning the SpringExtension must run before the JGivenExtension. This is now enforced. Unfortunately, the original JUnit5 ScenarioTest (and similar) cannot be used any longer because they already contain the JGivenExtension. Signed-off-by: Fabian Kneißl <fabian.kneissl@tngtech.com>
catchin
force-pushed
the
spring-junit5-additional-stage-fix
branch
from
960ddf5 to
7c2f6b4
Compare
fudler
approved these changes
Oct 6, 2020
l-1squared
approved these changes
Oct 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that the JUnit5 Extensions have to be executed in the correct order, meaning the SpringExtension must run before the JGivenExtension. This is now enforced. Unfortunately, the original JUnit5 ScenarioTest (and similar) cannot be used any longer because they already contain the JGivenExtension.
Signed-off-by: Fabian Kneißl fabian.kneissl@tngtech.com
Note that it would be good to also merge #493 so that the tests are actually executed :)