Skip to content

Improve our github workflows for Java 25 and manual trigger #856

@bnouwt

Description

@bnouwt

When releasing Knowledge Engine version 1.5.0 which upgraded the KE to Java version 25, the publication of docker images for this version failed, because Java 25 was not the default Java on the used runner virtual machine. We've fixed it by manually building and pushing the 1.5.0 docker images.

This, however, does not make our GitHub workflows suitable for Java 25 and so next image releases will fail as well. To make it suitable for Java 25, there are several options. The first is specifying a docker image to use when executing steps like this:

jobs:
  setup:
    runs-on: ubuntu-latest
    container:
      image: maven:3.9.14-eclipse-temurin-25

The second is specifying the JAVA_HOME environment variable that the mvn command uses to JAVA_HOME_25_X64 and make sure it uses Java 25.

An additional thing to fix within this issue is to make the docker image release workflow parameterized for manual trigger. This way if the release of the docker image fails, we can trigger it manually afterwards instead of building it locally and pushing it ourselves.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions