Add POST/ASK interactions to knowledge base and client#18
Merged
Conversation
Sophietje
reviewed
May 20, 2026
| from .kb import TestBinding, ask_for_values_of_subject, kb, repeat_value_post | ||
|
|
||
| # In your tests you likely want to use the TestClient to mock results from the KE. | ||
| # A Knowledge Base instance is initialized with a real Client that makes HTTP requests |
There was a problem hiding this comment.
Might be worth it to extend the documentation on the knowledge mapper at some point (https://docs.knowledge-engine.eu/get-started/knowledge-base/knowledge-mapper)
Contributor
Author
There was a problem hiding this comment.
Agreed! Will do soon
Sophietje
reviewed
May 20, 2026
Sophietje
reviewed
May 20, 2026
Sophietje
reviewed
May 20, 2026
Sophietje
reviewed
May 20, 2026
| name="ask-ki", | ||
| graph_pattern=""" | ||
| ?person a ex:Person . | ||
| ex:hasName ?name . |
There was a problem hiding this comment.
Use ; (instead of .) as you're reusing the subject in the following clauses
Sophietje
reviewed
May 20, 2026
Sophietje
reviewed
May 20, 2026
Sophietje
reviewed
May 20, 2026
Sophietje
reviewed
May 20, 2026
Sophietje
reviewed
May 20, 2026
Sophietje
reviewed
May 20, 2026
Sophietje
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #15
This PR adds POST and ASK interactions to the Knowledge Base and KE Client.
The TestClient is moved to src, to be used by users of the package as well.