bugfix/fix-key-issue-tns-alerts #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcollom
approved these changes
Oct 30, 2020
tom_alerts/brokers/tns.py
Outdated
| 'public_timestamp': public_timestamp, | ||
| }) | ||
| } | ||
| print("About to send payload to TNS", data) |
Contributor
There was a problem hiding this comment.
Can you either remove the print statements or replace them with logging statements? Our logging is pretty poor at present, but the best example is in tom_common/hooks.py.
tom_alerts/brokers/tns.py
Outdated
| public_timestamp = '' | ||
| data = { | ||
| 'api_key': settings.BROKER_CREDENTIALS['TNS_APIKEY'], | ||
| 'api_key': settings.ALERT_CREDENTIALS['TNS']['api_key'], |
Contributor
There was a problem hiding this comment.
So, the move is actually going to be to call this settings BROKERS, as currently our facility info is stored in settings.FACILITIES (it holds more than just credentials). Can you make the name BROKERS instead?
dmcollom
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dictionary key issues in the TNS API key and also in the response from the TNS. Fully tested.
Performed as per the Contributing instructions git workflow;
Forked, Branched, Fixed, Committed, Merged, Pushed to Fork, Creation of pull request.
Hope this is all good!