-
Notifications
You must be signed in to change notification settings - Fork 4
Rework ClayWorkTable GUI #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the ClayWorkTable GUI from legacy Minecraft containers to ModularUI framework and fixes a bug allowing items in output slots.
- Reworked ClayWorkTable GUI implementation using ModularUI
- Added utility classes for manageable button states and textures
- Removed legacy GUI components and fixed output slot input validation
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| JeiPlugin.kt | Removed reference to legacy GuiClayWorkTable class |
| ContainerClayWorkTable.kt | Removed legacy container implementation |
| ClayGuiTextures.kt | Added explicit UITexture type annotations and WorkTable texture definitions |
| ButtonUiTextures.kt | New utility class for organizing button texture states |
| ButtonToggleable.kt | New ModularUI button widget with enabled/disabled state support |
| TileClayWorkTable.kt | Implemented ModularUI interface and GUI building logic |
| BlockClayWorkTable.kt | Updated to use ModularUI factory instead of legacy GUI handler |
| GuiHandler.kt | Removed ClayWorkTable-related handler code |
| GuiButtonImageToggleable.kt | Removed legacy button implementation |
| GuiClayWorkTable.kt | Removed legacy GUI implementation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...main/kotlin/io/github/trcdevelopers/clayium/common/blocks/clayworktable/TileClayWorkTable.kt
Show resolved
Hide resolved
...main/kotlin/io/github/trcdevelopers/clayium/common/blocks/clayworktable/TileClayWorkTable.kt
Show resolved
Hide resolved
soramame0256
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What
Implementation Details
ButtonToggleableクラスを作成ButtonUiTexturesクラスを作成UITextureを取得できるようにした。Outcome