Skip to content

Conversation

@bqc0n
Copy link
Member

@bqc0n bqc0n commented Oct 4, 2025

What

  • ClayWorkTableのGUIをModularUIへ移行
  • 出力スロットにアイテムを入れられるバグを修正

Implementation Details

  • ButtonToggleableクラスを作成
    • enabled/disabled の状態を持つボタン
  • ButtonUiTexturesクラスを作成
    • テクスチャファイルで、ボタンのテクスチャは上から disabled,enabled,hovered の状態で並んでいる。それらすべてのxyuvを指定するのは冗長なので、disabledのxyuvだけで3種すべてのUITextureを取得できるようにした。
    • もっと良い名前があるかもしれない

Outcome

@github-actions github-actions bot added the bug Something isn't working label Oct 4, 2025
@bqc0n bqc0n requested review from Copilot and soramame0256 October 4, 2025 09:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the ClayWorkTable GUI from legacy Minecraft containers to ModularUI framework and fixes a bug allowing items in output slots.

  • Reworked ClayWorkTable GUI implementation using ModularUI
  • Added utility classes for manageable button states and textures
  • Removed legacy GUI components and fixed output slot input validation

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
JeiPlugin.kt Removed reference to legacy GuiClayWorkTable class
ContainerClayWorkTable.kt Removed legacy container implementation
ClayGuiTextures.kt Added explicit UITexture type annotations and WorkTable texture definitions
ButtonUiTextures.kt New utility class for organizing button texture states
ButtonToggleable.kt New ModularUI button widget with enabled/disabled state support
TileClayWorkTable.kt Implemented ModularUI interface and GUI building logic
BlockClayWorkTable.kt Updated to use ModularUI factory instead of legacy GUI handler
GuiHandler.kt Removed ClayWorkTable-related handler code
GuiButtonImageToggleable.kt Removed legacy button implementation
GuiClayWorkTable.kt Removed legacy GUI implementation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@soramame0256 soramame0256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bqc0n bqc0n merged commit 172b714 into develop Oct 4, 2025
3 checks passed
@bqc0n bqc0n deleted the fix-clayworktable-output branch October 4, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clay Work Table: シフトクリックでアウトプットにアイテムを入れられる

3 participants