Fix GL Error Invalid Enum #377
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes this:
Implementation Details
This is caused in the logic for getting
GL11.GL_SHADE_MODELinCRenderUtils. The buffer version is bit shifted to the left by 8 bits, leading to the invalid enum. If actual value isGL11.GL_FLAT(0x0x1D00), then shadeModel variable will be 0x1D0000.Therefore, you should use
GL11.glGetInteger(GL11.GL_SHADE_MODEL)instead of buffer version.Outcome
No more GL ERROR spam.