-
Notifications
You must be signed in to change notification settings - Fork 4
Update ModularUI to 3.0.4 #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the ModularUI dependency from version 3.0.3 to 3.0.4 and addresses breaking API changes introduced in the new version. The deprecated ResizingTextWidget class is removed and replaced with standard TextWidget instances configured with explicit width and alignment properties.
Key changes:
- Dependency version updates for ModularUI (3.0.4) and Forgelin (2.2.20.0)
- Migration from
HandGuiDatatoPlayerInventoryGuiDataandItemGuiFactorytoPlayerInventoryGuiFactory - Replacement of
debugName()method calls withname() - Removal of
ResizingTextWidgetclass and its factory functionasWidgetResizing()
Reviewed Changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| gradle/scripts/mod_dependencies.gradle | Updates ModularUI dependency from 3.0.3 to 3.0.4 |
| ClayiumMod.kt | Updates dependency version requirements in @mod annotation |
| ResizingTextWidget.kt | Removes deprecated custom widget class |
| CUtils.kt | Removes asWidgetResizing() extension function and unused imports |
| ItemFilterBase.kt | Migrates to PlayerInventoryGuiData and PlayerInventoryGuiFactory APIs |
| ItemStringItemFilter.kt, ItemSimpleItemFilter.kt, ItemFuzzyItemFilter.kt, ItemFilterDuplicator.kt | Updates buildUI signature to use PlayerInventoryGuiData |
| ItemClayGadgetHolder.kt | Migrates to new GUI factory API and data type |
| CaReactorMetaTileEntity.kt and others | Replaces asWidgetResizing() with asWidget() and explicit width/alignment |
| AutoTraderMetaTileEntity.kt, WorkableMetaTileEntity.kt | Replaces deprecated debugName() with name() |
| Various MetaTileEntity files | Removes unused imports for deprecated APIs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...tlin/io/github/trcdevelopers/clayium/common/metatileentities/RangedReplacerMetaTileEntity.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/io/github/trcdevelopers/clayium/api/capability/impl/LaserEnergyHolder.kt
Outdated
Show resolved
Hide resolved
soramame0256
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What
ResizingTextWidget, because it is using internal API and incompatible with 3.0.3TextWidgets with width and alignment are setHandGuiDatahas been deprecated in favor ofPlayerInventoryGuiDatadebugNamemethod has been deprecated in favor ofname