feat(ts): cross-impl golden tests against fixtures.toml (rebased from #68)#69
Merged
Merged
Conversation
Cherry-picked from PR #68 (closed; stale base would have reverted PR #67's Python pin work + the v1-3-fields-probe Rust binary). The new test loads /Users/tsavo/provekit/conformance/fixtures.toml at test time and asserts the TS canonicalizer produces byte-identical JCS bytes for each fixture. Closes the gap PR #17 noted: "TS golden is TS-vs-TS only — Rust-side byte-equality fixture needs minting". Now TS verifies against the canonical Rust-emitted bytes the conformance harness pins, not against its own derivation. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis PR introduces a new Vitest cross-implementation golden test that loads TOML fixtures, parses fixture blocks with multi-line string support, builds IR formulas for recognized fixture names, and validates that the TypeScript canonicalizer's serialized output matches Rust-emitted expected bytes and hash values. ChangesCross-Implementation Golden Test
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
There was a problem hiding this comment.
Pull request overview
This PR adds a new TypeScript conformance test intended to compare the TS canonicalizer against the repository’s shared conformance/fixtures.toml goldens, so the TS implementation can be checked against Rust-emitted fixture bytes and hashes instead of only TS-vs-TS expectations.
Changes:
- Adds
cross-impl-golden.test.tsunder the TS canonicalizer tests. - Loads
conformance/fixtures.toml, parses fixture entries, and builds matching TS-side formulas for supported fixture names. - Asserts serialized JCS bytes and BLAKE3-512 CIDs against the shared golden fixtures, while skipping non-formula fixtures.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+63
to
+70
| if (inJcs) { | ||
| if (line.endsWith("'")) { | ||
| jcsBuffer += line.slice(0, -1); | ||
| current.jcs = jcsBuffer; | ||
| inJcs = false; | ||
| jcsBuffer = ""; | ||
| } else { | ||
| jcsBuffer += line; |
Comment on lines
+219
to
+225
| const ast = formulaToCanonicalAst(formula); | ||
| const bytes = serializeCanonicalAst(ast); | ||
| const actualJcs = bytes.toString("utf8"); | ||
|
|
||
| expect(actualJcs, `JCS byte mismatch for "${fixture.name}"`).toBe( | ||
| fixture.jcs, | ||
| ); |
Comment on lines
+205
to
+212
| const formulaFixtures = allFixtures.filter((f) => buildFormulaFor(f.name) !== null); | ||
| const nonFormulaFixtures = allFixtures.filter((f) => buildFormulaFor(f.name) === null); | ||
|
|
||
| describe("cross-impl golden: TS canonicalizer vs Rust-emitted fixtures", () => { | ||
| it.runIf(nonFormulaFixtures.length > 0)( | ||
| `skipped ${nonFormulaFixtures.length} non-formula fixture(s): ${nonFormulaFixtures.map((f) => f.name).join(", ")} (contract/bridge declarations are not formula-level)`, | ||
| () => { | ||
| // informational only |
Comment on lines
+81
to
+84
| // Remove optional trailing comment after value | ||
| const commentIdx = value.indexOf("#"); | ||
| if (commentIdx !== -1) { | ||
| value = value.slice(0, commentIdx).trim(); |
TSavo
added a commit
that referenced
this pull request
May 12, 2026
Adversarial audit of the concept-hub library against a broad corpus of programming idioms across the substrate's 10 supported languages. Findings categorized P1/P2/P3 for PEP 1.8.0 planning. Baseline: 45 primitive op + 7 pattern-shape concept:* ops at main 21cd698. Missing concepts identified: 4 P1, 7 P2, 10 P3. Language-signature gaps identified: 19. Audit-only -- no concept ops minted, no transport-gap mementos created. Findings route to 1.8.0 issue planning. Co-authored-by: Claude Code <agentwopr@gmail.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picked the 239-LOC `cross-impl-golden.test.ts` from PR #68 (closed; stale base would have reverted PR #67's Python pin work + the v1-3-fields-probe Rust binary).
The test loads `/Users/tsavo/provekit/conformance/fixtures.toml` at test time and asserts the TS canonicalizer produces byte-identical JCS bytes for each fixture, plus matching BLAKE3-512 hashes.
Closes the gap PR #17 noted: "TS golden is TS-vs-TS only — Rust-side byte-equality fixture needs minting". Now TS verifies against the canonical Rust-emitted bytes the conformance harness pins, not its own derivation.
Test plan
Summary by CodeRabbit