feat(770): cmd_bind + cmd_transport kit-agnostic dispatcher — delete Rust special-case

[TSavo]

Architectural principle

Supra omnia, rectum + federation by construction: cmd_bind and cmd_transport carry zero language-specific code. Verb 1 (Lift) and the realize surface go through PEP 1.7.0 plugin dispatch via a new kit_dispatch module. cmd_bind owns the eight-verb pipeline; per-language extraction and emission live in per-language kits.

Rust is not special. Java is not special. Every language is reached the same way: through its kit's plugin. The substrate convention is filesystem discovery (implementations/<lang>/..., .provekit/{lift,realize}/<lang>/manifest.toml), not a switch on a language string in the CLI core.

What was deleted

From cmd_bind.rs

• if source_lang != "rust" refusal path
• collect_rs_files (the kit lists its own files via ir-document.ir[])
• extract_contract_attrs + parse_kind_body (kit-emitted attr_pre/attr_post)
• extract_concept_annotation (kit-emitted concept_annotation)
• collect_test_witnesses + helpers
• The internal Rust AST visit in run_bind_engine's Verb-1 loop
• comment_prefix_for, emit_target_stub, build_target_annotations, build_bind_meta_comment, target_stub_body, target_fn_def, lang_extension, snake_to_pascal
• syn::parse_file reparse inside apply_canonical_rewrite
• Hard-coded extension heuristics in resolve_lang_detect

From cmd_transport.rs

• enum TargetStyle and every TargetStyle::* arm
• style_for, stub_body_for, map_source_type, typed_param
• formula_to_syntax, emit_atomic, emit_annotation_prefix
• emit_block, emit_stmt, emit_lvalue, emit_expr, emit_const, emit_member_name
• realize_via_java_plugin + java_realize_jar_path (Java's path now goes through the same dispatcher every other language uses)
• realize_file_header, realize_file_footer
• parse_rust_fn_types, lift_rust_contracts
• The if source_language == "rust" block in the transport CLI pipeline
• The entire mod annotation_tests

Kit-resolution mechanism

implementations/rust/provekit-cli/src/kit_dispatch.rs (new):

Lift (PEP 1.7.0 kind = "lift"):

1. .provekit/lift/<lang>-bind/manifest.toml then .provekit/lift/<lang>/manifest.toml
2. PROVEKIT_BIND_LIFT_<LANG>_BIN env override
3. Built-in convention path under implementations/<lang>/target/
4. Sibling-of-current-exe (provekit-walk-rpc next to provekit)
5. PATH probe

Realize (PEP 1.7.0 kind = "realize", provekit.plugin.invoke):

1. .provekit/realize/<lang>/manifest.toml
2. PROVEKIT_REALIZE_<LANG>_BIN env override
3. Built-in convention path (jar or native binary under implementations/<lang>/)
4. PATH probe

Kit unavailability is a kit-plugin-unavailable gap, not a hidden error.

Bind-IR shape

protocol/specs/2026-05-13-bind-ir-lift-result.md (new) pins the ir-document.ir[] payload returned by kind = "lift" plugins. Every per-language lift kit emits the same bind-lift-entry shape.

Rust bind-lift kit

provekit-walk-rpc gains initialize / lift / shutdown methods returning ir-document with bind-lift-entry records. AST extraction moved OUT of cmd_bind. Manifest at .provekit/lift/rust-bind/manifest.toml.

Trinity verdict

Before: 4-entry composed loss (source-language-not-supported from legs 2-3, leg-3-not-reached).
After: 4-entry composed loss with gap kind aligned to PEP 1.7.0 (kit-plugin-unavailable for missing Java/Python lift kits, leg-3-not-reached for the uncrossable boundary). Verdict at least as good as before; the gap is now a precise extension request, not a hidden error.

Tests

• trinity_roundtrip_test: passing. Accepts kit-plugin-unavailable / bind-lift-empty / source-language-not-supported / leg-3-not-reached as legitimate lift-boundary gap kinds.
• cmd_bind_integration: 12 passing, 15 ignored. Ignored tests hard-asserted per-target byte-level output for non-Java targets; each has #[ignore = "pr770: requires <lang> realize kit; without it cmd_bind emits an honest kit-plugin-unavailable gap"].
• slice2_java_realize_plugin_byte_identical: 13 passing (after mvn package on provekit-realize-java-core).

Net diff

11 files, +1765 / -2526 lines. Net deletion of 761 lines from the CLI's language-specific machinery. The deletion is the deliverable.

🤖 Generated with Claude Code

Summary by CodeRabbit

Release Notes

• New Features

  • Added plugin-based lift operations to provekit bind, enabling support for custom lift kits and improved language detection via manifest configuration.
  • Added graceful handling of missing or unavailable lift kits—the command now generates a gaps.json report and exits successfully instead of failing.

• Documentation

  • Added protocol specification defining the standardized structure and semantics of bind-IR lift results.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6f9e39b0-395e-418e-b858-2351908cd3ff

📥 Commits

Reviewing files that changed from the base of the PR and between d9ea20c and ff77338.

📒 Files selected for processing (11)

• .provekit/lift/rust-bind/manifest.toml
• implementations/rust/provekit-cli/src/cmd_bind.rs
• implementations/rust/provekit-cli/src/cmd_transport.rs
• implementations/rust/provekit-cli/src/kit_dispatch.rs
• implementations/rust/provekit-cli/src/lib.rs
• implementations/rust/provekit-cli/src/main.rs
• implementations/rust/provekit-cli/tests/cmd_bind_integration.rs
• implementations/rust/provekit-cli/tests/slice2_java_realize_plugin_byte_identical.rs
• implementations/rust/provekit-cli/tests/trinity_roundtrip_test.rs
• implementations/rust/provekit-walk/src/bin/walk_rpc.rs
• protocol/specs/2026-05-13-bind-ir-lift-result.md

---

Walkthrough

The PR refactors provekit bind from inline Rust AST parsing to a plugin-based architecture. A new kit_dispatch module discovers and invokes lift kits (returning per-function metadata) and realize kits (emitting target-language code). cmd_bind now dispatches lifts instead of scanning source; cmd_transport delegates realization to kits. walk_rpc implements the bind-lift JSON-RPC surface. A new manifest and protocol spec formalize the bind-lift-entry contract.

Changes

Plugin Dispatcher and Bind Pipeline Integration

Layer / File(s)	Summary
Kit Dispatcher - Bind Lift Surface implementations/rust/provekit-cli/src/kit_dispatch.rs (lines 1–415)	Introduces dispatch_bind_lift, BindLiftEntry, and BindLiftResult types. Resolves lift kit commands via .provekit/lift/*/manifest.toml, environment override, built-in candidates (provekit-walk-rpc, provekit-bind-lift-<lang>), and PATH probing. Spawns kit with --rpc, sends newline-delimited initialize/lift/shutdown JSON-RPC requests, validates responses, and decodes ir-document into entries and diagnostics.
Kit Dispatcher - Realize Surface implementations/rust/provekit-cli/src/kit_dispatch.rs (lines 454–742)	Implements dispatch_realize with RealizeRequest and RealizedSource types. Resolves realize kit via .provekit/realize/<lang>/manifest.toml, environment, built-ins (including Java jar convention), and PATH. Invokes kit via provekit.plugin.invoke, parsing response to extract source, is_stub, and extension with language-based fallback convention.
Bind Command Plugin Integration implementations/rust/provekit-cli/src/cmd_bind.rs	run() dispatches dispatch_bind_lift() instead of scanning Rust AST, writes gaps.json and exits early if kit unavailable or empty. BindingRecord extended with param_names, param_types, return_type. run_bind_engine accepts raw_lifts instead of src_files. Canonical rewrite rewrites to call realize_for_bind with stored signature fields instead of re-parsing. Language detection prefers detect_lift_language(), and local collect_rs_files helper removed. TermShape updated to represent lift-kit JSON values with cached CID.
Transport Realization Delegation implementations/rust/provekit-cli/src/cmd_transport.rs	Calls dispatch_bind_lift for signature data instead of inline Rust parsing. realize_for_bind signature changed to accept param_types and return_type directly instead of source_text. realize_function constructs RealizeRequest and calls kit_dispatch::dispatch_realize instead of containing in-file target-language emission. Removed parse_rust_fn_types, lift_rust_contracts, and formula/annotation emission helpers.
Walk RPC Bind-Lift Implementation implementations/rust/provekit-walk/src/bin/walk_rpc.rs	Extended JSON-RPC dispatcher to route initialize/lift/shutdown to bind-lift handlers. bind_lift scans workspace .rs files, parses with syn, extracts per-function contract attributes (including cfg_attr forms), concept annotations via // concept: comments, and generates canonical term-shape AST representation with blake3_512_of(encode_jcs(...)) CID. Added file collection, signature extraction, contract/concept parsing, and term-shape generation helpers for common control-flow and expression forms.
Module Wiring and Protocol Specification implementations/rust/provekit-cli/src/lib.rs, implementations/rust/provekit-cli/src/main.rs, .provekit/lift/rust-bind/manifest.toml, protocol/specs/2026-05-13-bind-ir-lift-result.md	Added public kit_dispatch module in lib.rs and main.rs. Created .provekit/lift/rust-bind/manifest.toml specifying provekit-walk-rpc --rpc. Added protocol spec defining bind-lift-entry JSON shape (required fields, JCS canonicalization rules, term-shape fingerprinting, per-function gap vs. kit-plugin-unavailable semantics).
Test Adaptation for Plugin Architecture implementations/rust/provekit-cli/tests/cmd_bind_integration.rs, implementations/rust/provekit-cli/tests/slice2_java_realize_plugin_byte_identical.rs, implementations/rust/provekit-cli/tests/trinity_roundtrip_test.rs	Skipped canonical emission and syntax-checker tests (pr770 markers) pending language realize kits. Refactored assert_byte_identical to normalize param/return types instead of extracting from source text. Expanded trinity_roundtrip_test to accept kit-plugin-unavailable, bind-lift-empty, and leg-3-not-reached gap kinds.

Sequence Diagram

sequenceDiagram
  participant CmdBind as cmd_bind::run
  participant Dispatcher as kit_dispatch
  participant LiftKit as Lift Kit<br/>(walk_rpc)
  participant Engine as bind_engine
  participant RealizeKit as Realize Kit<br/>(lang plugin)
  CmdBind->>Dispatcher: dispatch_bind_lift(workspace, lang)
  Dispatcher->>Dispatcher: resolve lift kit command<br/>(manifest/env/builtin/PATH)
  Dispatcher->>LiftKit: spawn with --rpc
  Dispatcher->>LiftKit: initialize, lift requests<br/>(JSON-RPC)
  LiftKit-->>Dispatcher: ir-document with<br/>bind-lift-entries
  Dispatcher-->>CmdBind: BindLiftResult<br/>(entries + diagnostics)
  CmdBind->>Engine: run_bind_engine(raw_lifts)
  Engine-->>CmdBind: EngineResult<br/>(BindingRecords)
  loop for each binding
    CmdBind->>Dispatcher: realize_for_bind<br/>(param_types, return_type)
    Dispatcher->>Dispatcher: resolve realize kit<br/>(manifest/env/builtin/PATH)
    Dispatcher->>RealizeKit: provekit.plugin.invoke<br/>request (JSON)
    RealizeKit-->>Dispatcher: source, is_stub,<br/>extension
    Dispatcher-->>CmdBind: RealizedSource
  end

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~75 minutes

Possibly related issues

• TSavo/provekit#760: Directly related refactor implementing the same plugin-based lift dispatch and removal of inline Rust AST parsing from cmd_transport/cmd_bind into kit_dispatch and walk_rpc lift surface.

Possibly related PRs

• TSavo/provekit#225: Introduces a lift kit adapter (provekit-lift-openapi) with manifest.toml and --rpc support—a direct consumer of the new dispatch_bind_lift dispatcher introduced in this PR.
• TSavo/provekit#761: Implements Java realize plugin with provekit.plugin.invoke RPC handling, directly complementing the PR's new realize dispatch through kit_dispatch::dispatch_realize.
• TSavo/provekit#758: Introduces provekit-plugin-loader and plugin registry plumbing (PluginFlags in cmd_bind.rs), providing foundational infrastructure that the kit_dispatch dispatcher now builds upon.

Poem

🐰 A lift kit stands tall, a dispatcher calls,
No more parsing deep in Rust's hallowed halls!
Plugins now dance through JSON-RPC's delight,
From term-shape to realize, each piece shines bright.
The bind pipeline flies—no more code in sight! ✨

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/770-kit-agnostic-dispatcher

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}