Skip to content

use logger instead of print && upgrade to 1.3.0a5 #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2018
Merged

use logger instead of print && upgrade to 1.3.0a5 #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
Change history
==============

1.3.0a5 (2018-11-20)

* traceback.print_exc() --> logging.error.

1.3.0a4 (2018-11-15)

* Add ErrHandler.handler_assertion_error.
Expand Down
2 changes: 1 addition & 1 deletion hobbit_core/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
VERSION = [1, 3, 0, 'a4']
VERSION = [1, 3, 0, 'a5']
6 changes: 4 additions & 2 deletions hobbit_core/flask_hobbit/err_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
# -*- encoding: utf-8 -*-
import traceback
import logging

from sqlalchemy.orm import exc as orm_exc

from .response import Result, ServerErrorResult, gen_response, RESP_MSGS

logger = logging.getLogger(__name__)


class ErrHandler(object):
"""Base error handler that catch all exceptions. Be sure response is::
Expand Down Expand Up @@ -44,7 +46,7 @@ def handler_assertion_error(cls, e):

@classmethod
def handler_others(cls, e):
traceback.print_exc()
logging.error('UncheckedException:', exc_info=1)
return ServerErrorResult(code=500, detail=repr(e))

@classmethod
Expand Down