Conversation
…consistent 401 JSON response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a comprehensive authentication and authorization system using JWT and Spring Security, along with improvements to user management and error handling. Key additions include new dependencies for security, configuration classes for JWT and security, controller endpoints for authentication and user info, and enhanced validation and error codes.
Authentication & Security Setup:
pom.xmlto enable secure authentication and token management.SecurityConfigandJwtTokenConfigclasses to configure stateless JWT authentication, public endpoints, password encoding, and key rotation for tokens. [1] [2]CustomBearerTokenAuthenticationEntryPointfor standardized authentication error responses.SecurityConstantsfor managing public authentication endpoints.Authentication & User Endpoints:
AuthenticationControllerto support user registration, login, and token refresh endpoints, using new request DTOs for validation and separating user creation from authentication logic. [1] [2] [3]UserControllerwith an endpoint to retrieve the currently authenticated user's details.DTO & Validation Improvements:
LoginRequestandRefreshTokenRequestDTOs with validation annotations for authentication flows. [1] [2]UserCreationRequestandUserResponseDTOs for better security and clarity, including exclusion of sensitive fields fromtoStringand explicit timestamp handling. [1] [2]AuthenticationResponseto include both access and refresh tokens.Error Handling:
ErrorCodeenum to cover authentication, token, and user-related errors for consistent API error responses.Mapping Logic:
UserMapperto ignore sensitive and system-generated fields during user creation mapping, ensuring proper initialization and security.