[FEATURE] Add stream_context option to WebOpcacheResetExecuteTask#79
Merged
helhum merged 2 commits intoTYPO3:masterfrom Sep 5, 2017
sabbelasichon:feature/web-opcache-reset-execute-task-with-context
Merged
[FEATURE] Add stream_context option to WebOpcacheResetExecuteTask#79helhum merged 2 commits intoTYPO3:masterfrom sabbelasichon:feature/web-opcache-reset-execute-task-with-context
helhum merged 2 commits intoTYPO3:masterfrom
sabbelasichon:feature/web-opcache-reset-execute-task-with-context
Conversation
Collaborator
sabbelasichon
commented
Apr 6, 2017
- This is useful for example to execute the task if we have to provide Basic Authentication
…cuteTask - This is useful for example to execute the task if we have to provide Basic Authentication
helhum
suggested changes
Apr 6, 2017
| } | ||
|
|
||
| $context = null; | ||
| if (isset($options['context']) && is_array($options['context'])) { |
Contributor
There was a problem hiding this comment.
can you please call that stream_context
Collaborator
Author
There was a problem hiding this comment.
Sure. Only the option? Or the variable too?
Collaborator
|
Fixes #83 |
Collaborator
Author
|
I have fixed it. Hope everything is fine now. |
Collaborator
|
great. Maybe some documentation how to use it? |
Collaborator
Author
|
You can now just pass the option stream_context to the task TYPO3\Surf\Task\Php\WebOpcacheResetExecuteTask: $workflow->setTaskOptions('TYPO3\\Surf\\Task\\Php\\WebOpcacheResetExecuteTask',array(
'baseUrl' => $baseUrl,
'stream_context' => array(
'http' => array(
'header' => 'Authorization: Basic '.base64_encode("username:password"),
),
),
)); |
helhum
approved these changes
Sep 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.