Skip to content

[TASK] Adjust .gitattributes export behavior#56

Merged
ohader merged 2 commits intoTYPO3:v2from
longwave:patch-2
Dec 10, 2019
Merged

[TASK] Adjust .gitattributes export behavior#56
ohader merged 2 commits intoTYPO3:v2from
longwave:patch-2

Conversation

@longwave
Copy link
Copy Markdown
Contributor

The release package contains an unnecessary file.

@longwave
Copy link
Copy Markdown
Contributor Author

See #55

@longwave longwave closed this Nov 20, 2019
@ohader ohader reopened this Nov 20, 2019
@ohader
Copy link
Copy Markdown
Member

ohader commented Nov 20, 2019

It looks correct, AppVeyor has a couple of hickups (which I did not analyze in detail)...

@ohader ohader changed the title Do not export Appveyor config [TASK] Adjust .gitattributes export behavior Nov 20, 2019
@ohader
Copy link
Copy Markdown
Member

ohader commented Nov 20, 2019

Back-port in #57

@ohader
Copy link
Copy Markdown
Member

ohader commented Nov 20, 2019

@longwave Thanks for your changes. Why did you close previous pull-requests, it looked okay to me. Are there any aspects I'm currently missing? Thanks in advance for your feedback!

@longwave
Copy link
Copy Markdown
Contributor Author

longwave commented Nov 20, 2019

Sorry, I saw the Appveyor builds failing and I thought it was because of this change it couldn't find the config file, maybe I was wrong though. I raised this because I used the release tarball to create a patch for Drupal 7 core at https://www.drupal.org/project/drupal/issues/3085098 and it was noted over there that the .appveyor.yml file should perhaps not be included.

@ohader
Copy link
Copy Markdown
Member

ohader commented Nov 20, 2019

@longwave Alright & no problem at all... restarting AppVeyor helped in the past...
For me it would be okay to merge these changes and tag new v2.1.4 and v3.1.4 versions of the package.

@@ -1,8 +1,11 @@
/_config.yml
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to set export-ignore here?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's available in master only... shouldn't do any harm in v2 branch, does it?

@ohader ohader merged commit ade6937 into TYPO3:v2 Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants