[TASK] Stop storing development tool PHARs in the repository#1277
Merged
DanielSiepmann merged 1 commit intomainfrom May 7, 2024
Merged
[TASK] Stop storing development tool PHARs in the repository#1277DanielSiepmann merged 1 commit intomainfrom
DanielSiepmann merged 1 commit intomainfrom
Conversation
Pull Request Test Coverage Report for Build 8983253365Details
💛 - Coveralls |
Tools that are downloadable should in general be downloaded during the CI runs, not stored in the repository. As the only PHIVE PHAR we're using is PCOV (for code coverage, which we usually only run on CI), we can skip providing PHIVE and rely on CI to provide PHIVE for us. This leaves only PCOV to be installed via PHIVE. Fixes #267
oliverklee
force-pushed
the
task/no-phars-in-repo
branch
from
b0aeb30 to
ec20492
Compare
Contributor
Author
|
How to test: Check that the code coverage CI job runs through. |
DanielSiepmann
approved these changes
May 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tools that are downloadable should in general be downloaded during the CI runs, not stored in the repository.
As the only PHIVE PHAR we're using is PCOV (for code coverage, which we usually only run on CI), we can skip providing PHIVE and rely on CI to provide PHIVE for us. This leaves only PCOV to be installed via PHIVE.
Fixes #267