[TASK] Use PHP 8.3 by default in runTests.sh#1287
Conversation
Pull Request Test Coverage Report for Build 8985201237Details
💛 - Coveralls |
sbuerk
left a comment
There was a problem hiding this comment.
Personally I prefere to use the minimum version locally to ensure early (locally) not to use syntax only available in higher versions.
Performance in runTests.sh for tests and tools should be negitable.
On the otherhand, it's a question of preference and technically absolutly fine to use PHP8.3 as both cores support them and all related tools.
Let's use the most performant available PHP version for local development.
|
If this is about performance: Should we do the same for all other versions, e.g. database as well? I'd prefer to streamline the highest / lowest version throughout all the usages. TYPO3 has highest value by default. Or should that be a different issue? |
Let's do that for the DBMS versions in a separate issue. (And I'm all for using the highest possible version for the supported TYPO3 versions by default.) |
The point is, that all other dbms are possible to use the minimum version for TYPO3 v11 and v12. For MySQL that's not the case. TYPO3 v12 supports only 8.0+, TYPO3 MySQL 5.5+. So using minimumb version as default will fail against v11 core and my not be obvoius to see. MySQL is the version working for both core versions as minimal surface as default. PHP8.0 <->PHP8.3 is possible for both versions, so there are 3 version to pick as a shared possibility. Otherwise, the default needs to be "TYPO3 version aware". |
Let's use the most performant available PHP version for local development.