Skip to content

[TASK] Use PHP 8.3 by default in runTests.sh#1287

Merged
oliverklee merged 1 commit intomainfrom
task/php83
May 7, 2024
Merged

[TASK] Use PHP 8.3 by default in runTests.sh#1287
oliverklee merged 1 commit intomainfrom
task/php83

Conversation

@oliverklee
Copy link
Copy Markdown
Contributor

Let's use the most performant available PHP version for local development.

@oliverklee oliverklee added this to the 4.0.0: Breaking changes milestone May 7, 2024
@oliverklee oliverklee self-assigned this May 7, 2024
@coveralls
Copy link
Copy Markdown

coveralls commented May 7, 2024

Pull Request Test Coverage Report for Build 8985201237

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 8985126750: 0.0%
Covered Lines: 46
Relevant Lines: 46

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@sbuerk sbuerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I prefere to use the minimum version locally to ensure early (locally) not to use syntax only available in higher versions.
Performance in runTests.sh for tests and tools should be negitable.

On the otherhand, it's a question of preference and technically absolutly fine to use PHP8.3 as both cores support them and all related tools.

Let's use the most performant available PHP version for
local development.
Copy link
Copy Markdown
Contributor

@lukaszuznanski lukaszuznanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that it's working on local env.

@DanielSiepmann
Copy link
Copy Markdown
Contributor

If this is about performance: Should we do the same for all other versions, e.g. database as well?
mysql for some reason is the only dbms where the highest version is the default.

I'd prefer to streamline the highest / lowest version throughout all the usages. TYPO3 has highest value by default. Or should that be a different issue?

@oliverklee
Copy link
Copy Markdown
Contributor Author

I'd prefer to streamline the highest / lowest version throughout all the usages. TYPO3 has highest value by default. Or should that be a different issue?

Let's do that for the DBMS versions in a separate issue. (And I'm all for using the highest possible version for the supported TYPO3 versions by default.)

@oliverklee oliverklee merged commit 38b50bd into main May 7, 2024
@oliverklee oliverklee deleted the task/php83 branch May 7, 2024 12:32
@sbuerk
Copy link
Copy Markdown
Contributor

sbuerk commented May 7, 2024

If this is about performance: Should we do the same for all other versions, e.g. database as well? mysql for some reason is the only dbms where the highest version is the default.

I'd prefer to streamline the highest / lowest version throughout all the usages. TYPO3 has highest value by default. Or should that be a different issue?

The point is, that all other dbms are possible to use the minimum version for TYPO3 v11 and v12. For MySQL that's not the case. TYPO3 v12 supports only 8.0+, TYPO3 MySQL 5.5+. So using minimumb version as default will fail against v11 core and my not be obvoius to see. MySQL is the version working for both core versions as minimal surface as default.

PHP8.0 <->PHP8.3 is possible for both versions, so there are 3 version to pick as a shared possibility.

Otherwise, the default needs to be "TYPO3 version aware".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants