Skip to content

[FEATURE] Add PHP mess detector#1391

Merged
oliverklee merged 10 commits intomainfrom
feature/addPhpMessDetector
Jul 31, 2024
Merged

[FEATURE] Add PHP mess detector#1391
oliverklee merged 10 commits intomainfrom
feature/addPhpMessDetector

Conversation

@Starkmann
Copy link
Copy Markdown
Contributor

Resolves: #128

@Starkmann Starkmann added this to the 4.0.0: Breaking changes milestone Jul 29, 2024
@Starkmann Starkmann requested a review from oliverklee July 29, 2024 17:37
@Starkmann Starkmann self-assigned this Jul 29, 2024
@coveralls
Copy link
Copy Markdown

coveralls commented Jul 29, 2024

Pull Request Test Coverage Report for Build 10177161066

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 10168405813: 0.0%
Covered Lines: 46
Relevant Lines: 46

💛 - Coveralls

@oliverklee oliverklee added the enhancement New feature or request label Jul 30, 2024
Comment thread composer.json Outdated
Comment thread composer.json Outdated
Comment thread composer.json Outdated
Comment thread Build/phpmd.xml Outdated
Comment thread Build/phpmd.xml Outdated
@Starkmann Starkmann force-pushed the feature/addPhpMessDetector branch from 0a8ed5a to 22e82f1 Compare July 30, 2024 17:07
@oliverklee oliverklee changed the title [FEATURE] Add php mess detector [FEATURE] Add PHP mess detector Jul 30, 2024
Comment thread Build/phpmd.xml Outdated
Comment thread Build/phpmd.xml Outdated
Comment thread composer.json Outdated
Comment thread composer.json
Starkmann added a commit that referenced this pull request Jul 30, 2024
Starkmann added a commit that referenced this pull request Jul 30, 2024
Starkmann added a commit that referenced this pull request Jul 30, 2024
Starkmann added a commit that referenced this pull request Jul 30, 2024
@Starkmann Starkmann force-pushed the feature/addPhpMessDetector branch from 75d39b6 to cd68b6b Compare July 30, 2024 17:37
Comment thread .github/workflows/ci.yml Outdated
Comment thread composer.json Outdated
Starkmann added a commit that referenced this pull request Jul 30, 2024
Starkmann added a commit that referenced this pull request Jul 30, 2024
Copy link
Copy Markdown
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could you please rebase and resolve the merge conflict?

@Starkmann Starkmann force-pushed the feature/addPhpMessDetector branch from 90a69ac to 05ebe2f Compare July 31, 2024 08:55
@oliverklee oliverklee merged commit 6c8f017 into main Jul 31, 2024
@oliverklee oliverklee deleted the feature/addPhpMessDetector branch July 31, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add PHPMD (PHP mess detector)

3 participants