Skip to content

[TASK] Rework the testing framework section in the docs#1480

Merged
oliverklee merged 9 commits intoTYPO3BestPractices:mainfrom
SalmanDeveloperz:rework/testing-framework-section
Oct 6, 2024
Merged

[TASK] Rework the testing framework section in the docs#1480
oliverklee merged 9 commits intoTYPO3BestPractices:mainfrom
SalmanDeveloperz:rework/testing-framework-section

Conversation

@SalmanDeveloperz
Copy link
Copy Markdown
Contributor

This Pull Request reworks the documentation for the testing framework section, specifically addressing the deprecation of the Nimut testing framework. Key changes include:

  • Removed references to the Nimut testing framework, as it is no longer maintained.

  • Updated the documentation to reflect that the TYPO3 Core Testing Framework now supports multiple TYPO3 LTS versions simultaneously, making the unique selling point of the Nimut TF irrelevant.

These changes aim to clarify the current best practices for testing within TYPO3 and provide a more accurate and up-to-date guide for developers.

Please feel free to let me know if any modifications or confirmations are needed.

Related Issue
This PR addresses ticket #535.

Copy link
Copy Markdown
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that it's not relevant to choose a testing framework anymore, I think we can change this section of the documentation to be about the release and branching strategy and less about which TF to use. This then should involve a changed file heading and renaming this file.

@SalmanDeveloperz
Copy link
Copy Markdown
Contributor Author

Now that it's not relevant to choose a testing framework anymore, I think we can change this section of the documentation to be about the release and branching strategy and less about which TF to use. This then should involve a changed file heading and renaming this file.

I have renamed the file to ReleaseBranchingStrategy.rst and updated the content to reflect the release and branching strategies as per the feedback. Please feel free to let me know if any further modifications or confirmations are needed.

Copy link
Copy Markdown
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to include the new file from Documentation/Index.rst so it can get rendered.

With this command, you can render the documentation locally and check if there are any warnings:

./Build/Scripts/runTests.sh -s docsGenerate

You then can also view the rendered documentation by opening Documentation-GENERATED-temp/Index.html in your browser.

@SalmanDeveloperz
Copy link
Copy Markdown
Contributor Author

Hi,
I’ve made the requested changes:

Added the new file ReleaseBranchingStrategy to the Documentation/Index.rst so it can be rendered.
Ran the command ./Build/Scripts/runTests.sh -s docsGenerate to generate the documentation locally and checked for warnings. Everything appears to be in order.
I also reviewed the rendered documentation by opening Documentation-GENERATED-temp/Index.html in the browser, and it looks correct.
Please let me know if there's anything else I should adjust!
Thanks!

Copy link
Copy Markdown
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still warnings when rendering the documentation. Please have a look at the CI build (or build the documentation locally) and fix those warnings.

If you have questions for that, please feel free to ask!

@SalmanDeveloperz
Copy link
Copy Markdown
Contributor Author

Thank you for pointing out the warnings in the documentation. I’m not very familiar with handling CI actions, troubleshooting, or fixing warnings during the documentation rendering process. Could you help clarify the following points for me? I'll be very thankful to you.

Remove "# Added new entry here" from index.rst
@SalmanDeveloperz
Copy link
Copy Markdown
Contributor Author

Hi,
I’ve updated the index.rst file as per the previous feedback. Could you please review and confirm if everything looks good? Let me know if any further changes or improvements are needed.

Thank you!

Comment thread Documentation/TestingFramework.rst
Comment thread Documentation/ReleaseBranchingStrategy.rst Outdated
Comment thread Documentation/ReleaseBranchingStrategy.rst Outdated
Comment thread Documentation/ReleaseBranchingStrategy.rst Outdated
Adjusted the length of the '====' lines to align with the header text for consistent formatting
Updated the code to ensure that all line lengths are now limited to a maximum of 80 characters for better readability
Copy link
Copy Markdown
Contributor Author

@SalmanDeveloperz SalmanDeveloperz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review changes and let me know if any furture requirement needed.

Comment thread Documentation/ReleaseBranchingStrategy.rst Outdated
Comment thread Documentation/ReleaseBranchingStrategy.rst Outdated
Comment thread Documentation/TestingFramework.rst
Just drop this document (and the reference to it) altogether.
Copy link
Copy Markdown
Contributor Author

@SalmanDeveloperz SalmanDeveloperz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just removed the document and its reference as requirement. Please verified and let me know if any furture changing required.

Comment thread Documentation/TestingFramework.rst
Comment thread Documentation/Index.rst Outdated
@oliverklee oliverklee changed the title Rework the testing framework section in the docs [TASK] Rework the testing framework section in the docs Oct 6, 2024
Remove TestingFramework from Table of Contents.
Copy link
Copy Markdown
Contributor Author

@SalmanDeveloperz SalmanDeveloperz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just removed TestingFramework from Table of Contents.

@SalmanDeveloperz
Copy link
Copy Markdown
Contributor Author

Hi,
I've removed the TestingFramework from the Table of Contents as requested. I’ve also built the documentation locally, and it no longer shows any warnings or validation errors.
Please let me know if any further changes are needed.
Thank you!

Copy link
Copy Markdown
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@oliverklee oliverklee merged commit c99b073 into TYPO3BestPractices:main Oct 6, 2024
@oliverklee
Copy link
Copy Markdown
Contributor

Congratulations on your first merged PR for this project! 🎉

@SalmanDeveloperz
Copy link
Copy Markdown
Contributor Author

Thank you so much! 🎉 I really appreciate your guidance throughout the process. I’m excited to contribute more and continue learning from the team. Looking forward to the next challenge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation hacktoberfest hacktoberfest-accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants