Skip to content

[CLEANUP] Do not quote workflow/job names for GitHub actions#1671

Merged
oliverklee merged 1 commit intomainfrom
cleanup/no-action-name-quotes
May 5, 2025
Merged

[CLEANUP] Do not quote workflow/job names for GitHub actions#1671
oliverklee merged 1 commit intomainfrom
cleanup/no-action-name-quotes

Conversation

@oliverklee
Copy link
Copy Markdown
Contributor

@oliverklee oliverklee added this to the 4.0.0: Breaking changes milestone May 5, 2025
@oliverklee oliverklee requested a review from a team May 5, 2025 13:52
@oliverklee oliverklee self-assigned this May 5, 2025
@oliverklee oliverklee force-pushed the cleanup/no-action-name-quotes branch from 6575160 to 50aea50 Compare May 5, 2025 13:57
@coveralls
Copy link
Copy Markdown

coveralls commented May 5, 2025

Pull Request Test Coverage Report for Build 14838278110

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 14838257732: 0.0%
Covered Lines: 107
Relevant Lines: 107

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@kanow kanow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@oliverklee oliverklee force-pushed the cleanup/no-action-name-quotes branch from 50aea50 to 8d3b9ca Compare May 5, 2025 14:00
@oliverklee oliverklee enabled auto-merge (squash) May 5, 2025 14:01
@oliverklee oliverklee merged commit c2ee394 into main May 5, 2025
38 checks passed
@oliverklee oliverklee deleted the cleanup/no-action-name-quotes branch May 5, 2025 14:02
@github-project-automation github-project-automation Bot moved this from In review to Done in Best Practices code sprint May 5, 2025
@oliverklee
Copy link
Copy Markdown
Contributor Author

For the record:

sed -i -E "s/name: \"([^\"]+)\"/name: \1/" .github/workflows/*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants